Conversation
Collaborator
|
Just to record here what we discussed on Zoom: a user-input |
- Recognize 0.0 as a valid float in CheckFloat and tokenize. - Represent 0.0 as float_(prec,0,0,0) (instead of float_(prec,0,0)) so it is accepted by TestFloat. - Keep terms with floating-point coefficient 0.0 after sorting; they can be removed explicitly via Chop. - Allow Chop to accept 0 and 0.0 as arguments (although it would have not effect). - Fix related float-handling bugs in CoIf. - Add tests covering multiple representations of floating-point zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the bug in tokenize that lead to a crash for 0.0 as an input float:
float_, this is now also represented with four arguments:float_(prec,0,0,0). Previously, this wasfloat_(prec,0,0), but this was not a proper float according toTestFloatwhich expects four arguments infloat_.